Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix modulo for long type #39722

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

xiaocai2333
Copy link
Contributor

issue: #39640

Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 8, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (a3df278) to head (5f8b78c).
Report is 19 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39722       +/-   ##
===========================================
+ Coverage   69.40%   80.16%   +10.75%     
===========================================
  Files         302     1476     +1174     
  Lines       27077   204322   +177245     
===========================================
+ Hits        18794   163795   +145001     
- Misses       8283    34706    +26423     
- Partials        0     5821     +5821     
Components Coverage Δ
Client 79.44% <ø> (∅)
Core 69.40% <100.00%> (ø)
Go 81.89% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/bitset/common.h 94.11% <100.00%> (ø)
...e/src/exec/expression/BinaryArithOpEvalRangeExpr.h 100.00% <100.00%> (ø)

... and 1175 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 8, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 10, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 11, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9e6e477 into milvus-io:master Feb 11, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Feb 12, 2025
issue: #39640

master pr: #39722

---------

Signed-off-by: Cai Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants