Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: return topks when search in restful v2 #39812

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

smellthemoon
Copy link
Contributor

if nq>2, restful will flatten all the res. If one nq res has duplicate pks, the length of this slice will be less then topk. This pr
will attach topks in the output.

@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. labels Feb 12, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 12, 2025
Copy link
Contributor

mergify bot commented Feb 12, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 12, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.06%. Comparing base (3ab692e) to head (82f2b10).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39812      +/-   ##
==========================================
+ Coverage   80.04%   80.06%   +0.02%     
==========================================
  Files        1488     1488              
  Lines      205913   205913              
==========================================
+ Hits       164828   164872      +44     
+ Misses      35108    35077      -31     
+ Partials     5977     5964      -13     
Components Coverage Δ
Client 79.24% <ø> (ø)
Core 69.40% <ø> (ø)
Go 81.78% <66.66%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.72% <66.66%> (ø)

... and 32 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 12, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 12, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 13, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Feb 13, 2025
@smellthemoon
Copy link
Contributor Author

rerun go-sdk

sre-ci-robot pushed a commit that referenced this pull request Feb 14, 2025
Copy link
Contributor

mergify bot commented Feb 14, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Feb 14, 2025

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor

tedxu commented Feb 17, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smellthemoon, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 38cfd38 into milvus-io:master Feb 17, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants