Add check_for_pole to some poles
#117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables signs from the street_signs mod to use this mod's poles as a pole to correctly attach to.
SmallJoker
reviewed
Nov 12, 2023
streets_poles/init.lua
Outdated
| @@ -11,7 +11,7 @@ minetest.register_node(":streets:bigpole", { | |||
| drawtype = "nodebox", | |||
| tiles = { "streets_pole.png" }, | |||
| sunlight_propagates = true, | |||
| groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1}, | |||
There was a problem hiding this comment.
I don't know what it's there for, I didn't add it for any reason.
There was a problem hiding this comment.
This is here for advtrains. If a block is registered with this group, trains will not be blocked even if this block is in its path. This is useful as poles are not full blocks, hence not visually blocking trains but technically would.
SmallJoker
reviewed
Nov 12, 2023
SmallJoker
reviewed
Nov 12, 2023
Co-authored-by: SmallJoker <[email protected]>
I am untrained in version numbers, an explanation to why it goes from 2.0.1 to 2.1.0 would be nice
|
@sonicSMASH There a few nodes that still have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables signs from the street_signs mod to use this mod's poles as a pole to correctly attach to.