Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check_for_pole to some poles #117

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add check_for_pole to some poles #117

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4bcc4c
Add `check_for_pole` to some poles
sonicSMASH Nov 10, 2023
1a481df
Update mod.conf
sonicSMASH Nov 10, 2023
1da3b89
Update streets_poles/init.lua
sonicSMASH Dec 8, 2023
afa4027
Change version
sonicSMASH Dec 8, 2023
7ffab6e
Undo removing `not_blocking_trains`
sonicSMASH Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mod.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = streets
title = Streets
depends = default, stairs, ts_workshop, dye
optional_depends = creative, xpanes, stairsplus, moreblocks, digilines, concrete
optional_depends = creative, xpanes, stairsplus, moreblocks, digilines, concrete, signs_lib
license = MIT
version = 2.0.1
sonicSMASH marked this conversation as resolved.
Show resolved Hide resolved
author = webdesigner97
Expand Down
37 changes: 22 additions & 15 deletions streets_poles/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ minetest.register_node(":streets:bigpole", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
Copy link
Member

@SmallJoker SmallJoker Nov 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does not_blocking_trains do? Why can it be removed?

EDIT: Added in #109

@Emojigit What does this do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what it's there for, I didn't add it for any reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is here for advtrains. If a block is registered with this group, trains will not be blocked even if this block is in its path. This is useful as poles are not full blocks, hence not visually blocking trains but technically would.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, it got added back.

groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -39,7 +39,9 @@ minetest.register_node(":streets:bigpole", {
[3] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0 },
["t"] = { 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1 },
["b"] = { 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1 }
}
},
check_for_pole = true
sonicSMASH marked this conversation as resolved.
Show resolved Hide resolved

})

minetest.register_craft({
Expand All @@ -58,7 +60,7 @@ minetest.register_node(":streets:bigpole_short", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand All @@ -85,7 +87,8 @@ minetest.register_node(":streets:bigpole_short", {
[3] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 0, 0, 0, 0 },
["t"] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1 },
["b"] = { 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }
}
},
check_for_pole = true
})

minetest.register_craft({
Expand All @@ -103,7 +106,7 @@ minetest.register_node(":streets:bigpole_edge", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -131,7 +134,8 @@ minetest.register_node(":streets:bigpole_edge", {
[3] = { 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 1, 0, 1, 0, 0 },
["t"] = { 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1 },
["b"] = { 1, 1, 1, 1, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0 }
}
},
check_for_pole = true
})

minetest.register_craft({
Expand All @@ -158,7 +162,7 @@ minetest.register_node(":streets:bigpole_tjunction", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -186,7 +190,8 @@ minetest.register_node(":streets:bigpole_tjunction", {
[3] = { 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 0, 0, 0, 1, 1, 1, 1, 0, 1, 0, 1 },
["t"] = { 0, 0, 0, 0, 1, 0, 1, 0, 1, 0, 1, 0, 0, 1, 0, 1, 0, 1, 0, 1, 1, 1, 1, 1 },
["b"] = { 1, 1, 1, 1, 1, 0, 1, 0, 1, 0, 1, 0, 0, 1, 0, 1, 0, 1, 0, 1, 0, 0, 0, 0 }
}
},
check_for_pole = true
})

minetest.register_craft({
Expand All @@ -204,7 +209,7 @@ minetest.register_node(":streets:bigpole_corner", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -233,7 +238,8 @@ minetest.register_node(":streets:bigpole_corner", {
[3] = { 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0 },
["t"] = { 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1 },
["b"] = { 1, 1, 1, 1, 0, 0, 1, 1, 1, 1, 0, 0, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0 }
}
},
check_for_pole = true
})

minetest.register_craft({
Expand All @@ -252,7 +258,7 @@ minetest.register_node(":streets:bigpole_four_side_junction", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -300,7 +306,7 @@ minetest.register_node(":streets:bigpole_cross", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -348,7 +354,7 @@ minetest.register_node(":streets:bigpole_five_side_junction", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -395,7 +401,7 @@ minetest.register_node(":streets:bigpole_all_sides", {
drawtype = "nodebox",
tiles = { "streets_pole.png" },
sunlight_propagates = true,
groups = { cracky = 1, level = 2, bigpole = 1, not_blocking_trains = 1},
groups = { cracky = 1, level = 2, bigpole = 1 },
node_box = {
type = "fixed",
fixed = {
Expand Down Expand Up @@ -424,7 +430,8 @@ minetest.register_node(":streets:bigpole_all_sides", {
[3] = { 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1 },
["t"] = { 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1 },
["b"] = { 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1 }
}
},
check_for_pole = true
})

minetest.register_craft({
Expand Down