Fix deprecation warnings #1040
Merged
Fix deprecation warnings #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
reviewed
Jun 20, 2024
| @@ -85,7 +85,6 @@ let handle_client handle_request sock rd wr = | |||
| Http.Request.is_keep_alive req | |||
| && Http.Response.is_keep_alive res | |||
| in | |||
| let flush = Http.Response.flush res in | |||
There was a problem hiding this comment.
It's not clear to me we want to remove this completely - @rgrinberg what's the intended use for those nowadays?
There was a problem hiding this comment.
I think they're useless. Flushing should just be done for every request/response.
There was a problem hiding this comment.
flush defaults to true, so removing these lines is ok.
MisterDA
force-pushed
the
fix-deprecation-warnings
branch
from
5df470a to
d37bd5b
Compare
rgrinberg
reviewed
Jun 24, 2024
| ppx_expect.config_types | ||
| ppx_expect.common | ||
| base | ||
| ppx_inline_test.config) |
There was a problem hiding this comment.
I separated this change from updating to ppx_expect 0.17.0.
rgrinberg
reviewed
Jun 24, 2024
| @@ -168,7 +168,7 @@ module Request = struct | |||
| timeout | |||
| in | |||
| Cohttp_curl.Request.create ?timeout_ms ?headers method_ ~uri ~input | |||
| ~output ~on_response:(Ivar.fill response_ready) | |||
| ~output ~on_response:(Ivar.fill_exn response_ready) | |||
There was a problem hiding this comment.
Does this need a minimum version bump for async?
There was a problem hiding this comment.
Yes, async_kernel >= v0.17.0. I've added it to this PR.
Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
MisterDA
force-pushed
the
fix-deprecation-warnings
branch
from
d37bd5b to
0aced7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecation warnings, and the error that
ppx_expect.commonisn't found. As we're not using dune's explicit transitive deps feature (anymore?), they can be deleted from the dune file too.