-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netflify PR preview #420
Netflify PR preview #420
Conversation
24f80fe
to
eb62c44
Compare
Blocked by quarto-dev/netlify-plugin-quarto#2. |
I see how building via quarto on netlify seems to be the more idiomatic approach, but wouldn't it suffice to do the same as for a bookdown book, where the book is rendered on GitHub Actions and the output folder is pushed to netlify? |
Maybe, but I am not sure it will work. The linked repo only uses it to publish the final site and not as a preview proxy for PRs. I am not sure if this approach will work for the latter as I don't see any dynamic logic for PRs there. I'll check. |
No worries, I just had "I know I saw people have PR previews for bookdown..." in the back of my head - probably based on this writeup. If it ends up being too fiddly though I don't want to belabour the point :) |
Thanks, always good to ask and provide resources!
In general netlify is nothing new, we had it already for the old website and blog. Yet nobody carried it over when the old one was replaced by the new mlr3website repo (as nobody seemed to care about previews), the same applies for the book and the gallery. Good to see some interest in this! |
Solved by #477 |
fix #411
_freeze
folderquarto
via a pluginSource: https://quarto.org/docs/publishing/netlify.html#rendering-on-netlify