Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netflify PR preview #420

Closed
wants to merge 9 commits into from
Closed

Netflify PR preview #420

wants to merge 9 commits into from

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Sep 15, 2022

fix #411

  • Netlify cannot install R, hence we need the contents of the _freeze folder
  • Netflify must install quarto via a plugin

Source: https://quarto.org/docs/publishing/netlify.html#rendering-on-netlify

@mlr-org mlr-org deleted a comment from netlify bot Sep 15, 2022
@pat-s pat-s force-pushed the netlify branch 7 times, most recently from 24f80fe to eb62c44 Compare September 15, 2022 17:05
@pat-s
Copy link
Member Author

pat-s commented Sep 15, 2022

Blocked by quarto-dev/netlify-plugin-quarto#2.

@jemus42
Copy link
Member

jemus42 commented Sep 21, 2022

I see how building via quarto on netlify seems to be the more idiomatic approach, but wouldn't it suffice to do the same as for a bookdown book, where the book is rendered on GitHub Actions and the output folder is pushed to netlify?
See e.g. here https://github.com/EmilHvitfeldt/bookdown-github-actions-netlify/blob/master/.github/workflows/bookdown.yaml

@pat-s
Copy link
Member Author

pat-s commented Sep 25, 2022

Maybe, but I am not sure it will work. The linked repo only uses it to publish the final site and not as a preview proxy for PRs. I am not sure if this approach will work for the latter as I don't see any dynamic logic for PRs there. I'll check.

@jemus42
Copy link
Member

jemus42 commented Sep 25, 2022

No worries, I just had "I know I saw people have PR previews for bookdown..." in the back of my head - probably based on this writeup.

If it ends up being too fiddly though I don't want to belabour the point :)

@pat-s
Copy link
Member Author

pat-s commented Sep 25, 2022

Thanks, always good to ask and provide resources!

No worries, I just had "I know I saw people have PR previews for bookdown..." in the back of my head - probably based on this writeup.

In general netlify is nothing new, we had it already for the old website and blog. Yet nobody carried it over when the old one was replaced by the new mlr3website repo (as nobody seemed to care about previews), the same applies for the book and the gallery. Good to see some interest in this!

@be-marc
Copy link
Member

be-marc commented Nov 21, 2022

Solved by #477

@be-marc be-marc closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy branches / PRs for previewing via netlify
3 participants