Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add test case for markdown tables #1513

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

wagner-intevation
Copy link
Contributor

the markdown test cases were missing tests for the table extension

@wagner-intevation
Copy link
Contributor Author

I don't understand why the tests fail

        File "/tmp/pip-build-env-73m3_uf_/normal/lib/python3.10/site-packages/setuptools_scm/_get_version_impl.py", line 63, in write_version_files
          dump_version(
        File "/tmp/pip-build-env-73m3_uf_/normal/lib/python3.10/site-packages/setuptools_scm/_integration/dump_version.py", line 36, in dump_version
          assert not write_to.is_absolute(), f"{write_to=}"
      AssertionError: write_to=PosixPath('/home/runner/work/moin/moin/src/moin/_version.py')

Please give me a hint of where the issue originates from.

@UlrichB22
Copy link
Collaborator

I think this error is a general problem and not related to you changes. I will compare the CI logs with the logs of the latest successful run.

the markdown test cases were missing tests for the table extension
@wagner-intevation
Copy link
Contributor Author

rebased on master

@wagner-intevation
Copy link
Contributor Author

now the tests succeed as expected :)

@UlrichB22 UlrichB22 merged commit 826f66a into moinwiki:master Sep 20, 2023
@wagner-intevation wagner-intevation deleted the test-md-tables branch September 20, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants