Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for creating custom resolutions #1349

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaurilhoB
Copy link

Added an option for users to create their own custom resolutions in the desired aspect ratio. If the user has a phone with a 20:9 aspect ratio and a resolution of 2400x1080, they could scale it down to 1920x864 and still have full screen utilization.

I had this problem with my native resolution not being supported by the decoder, so I made this adjustment to enable full screen utilization simply by downscaling the resolution.

@quangmach
Copy link

Please merge this to master. This custom resolution has been requested for few years already. Thank you!

@zhoumother
Copy link

太感谢了

@kajdo
Copy link

kajdo commented May 11, 2024

I would love to see this becoming part of the official repo

@heloess
Copy link

heloess commented May 29, 2024

I can't thank you enough

@kaizendevsio
Copy link

kaizendevsio commented Jun 21, 2024

@cgutman please merge this to master when you have time, i love moonlight but this holds back a lot of people :)

@bshaoulian
Copy link

This would be a fantastic addition to the master repo

@danielmartina
Copy link

danielmartina commented Aug 13, 2024

Tested it as well on my device and it is a really useful functionality. It would be worth to merge it. Thank you Maurilho!

@survivor182ca
Copy link

Yes, please merge it because on samsung dex on my ultrawide monitor (3440x1440) i can t use on moonlight that resolution.

My only choice are 2560x1440 or 4k resolution

Thank in advance for your good work.😀

@ReenigneArcher
Copy link
Contributor

@LuisB79 I am not a maintainer here, but my guess is that it needs to be reviewed and properly tested.

import com.limelight.utils.Dialog;
import com.limelight.utils.UiHelper;

import java.lang.reflect.Method;
import java.util.Arrays;
import java.util.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know wildcard imports are used in a few other places, but I'm not sure it's a good practice.

Comment on lines +15 to +18
import android.widget.*;
import com.limelight.R;

import java.util.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment

<path
android:fillColor="#FFFFFF"
android:pathData="M17.114,3.923h-4.589V2.427c0-0.252-0.207-0.459-0.46-0.459H7.935c-0.252,0-0.459,0.207-0.459,0.459v1.496h-4.59c-0.252,0-0.459,0.205-0.459,0.459c0,0.252,0.207,0.459,0.459,0.459h1.51v12.732c0,0.252,0.207,0.459,0.459,0.459h10.29c0.254,0,0.459-0.207,0.459-0.459V4.841h1.511c0.252,0,0.459-0.207,0.459-0.459C17.573,4.127,17.366,3.923,17.114,3.923M8.394,2.886h3.214v0.918H8.394V2.886z M14.686,17.114H5.314V4.841h9.372V17.114z M12.525,7.306v7.344c0,0.252-0.207,0.459-0.46,0.459s-0.458-0.207-0.458-0.459V7.306c0-0.254,0.205-0.459,0.458-0.459S12.525,7.051,12.525,7.306M8.394,7.306v7.344c0,0.252-0.207,0.459-0.459,0.459s-0.459-0.207-0.459-0.459V7.306c0-0.254,0.207-0.459,0.459-0.459S8.394,7.051,8.394,7.306"/>
</vector>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</vector>
</vector>

Probably a good practice to have an empty blank line at the end of each file.

@Steso871
Copy link

Steso871 commented Nov 13, 2024

Added an option for users to create their own custom resolutions in the desired aspect ratio. If the user has a phone with a 20:9 aspect ratio and a resolution of 2400x1080, they could scale it down to 1920x864 and still have full screen utilization.

I had this problem with my native resolution not being supported by the decoder, so I made this adjustment to enable full screen utilization simply by downscaling the resolution.

Is this version available somewhere? Would love to try it on my tab a9+ that is refusing to use native resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.