Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch mulDiv version to OZ #42

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Switch mulDiv version to OZ #42

merged 2 commits into from
Nov 10, 2023

Conversation

MerlinEgalite
Copy link
Contributor

Not necessary but can be more trusted

@MerlinEgalite MerlinEgalite requested review from Rubilmax, QGarchery and a team November 9, 2023 14:59
@MerlinEgalite MerlinEgalite self-assigned this Nov 9, 2023
@MerlinEgalite MerlinEgalite requested review from Jean-Grimal, peyha and MathisGD and removed request for a team November 9, 2023 14:59
@MerlinEgalite MerlinEgalite mentioned this pull request Nov 9, 2023
Merged
Rubilmax
Rubilmax requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, OZ enforces 0.8.20 which introduces PUSH0

So either we don't use OZ, either we use `evm_version = 'paris'

@MerlinEgalite
Copy link
Contributor Author

MerlinEgalite commented Nov 10, 2023 •
edited
Loading

Unfortunately, OZ enforces 0.8.20 which introduces PUSH0

So either we don't use OZ, either we use `evm_version = 'paris'

Seen with @julien-devatom this is not a problem so let's implement the change!

@Rubilmax Rubilmax merged commit a73e817 into fix/512-bit-multiplication Nov 10, 2023
@Rubilmax Rubilmax deleted the refactor/usz-oz-version branch November 10, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal Jean-Grimal was automatically assigned from morpho-org/integration-team

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-org/protocol-team

@MathisGD MathisGD Awaiting requested review from MathisGD MathisGD was automatically assigned from morpho-org/protocol-team

Assignees

@MerlinEgalite MerlinEgalite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MerlinEgalite @Rubilmax