Add assumptions and acknowledgments

[MerlinEgalite]

Fixes https://github.com/cantinasec/review-morpho-blue-1/issues/72

[MathisGD]

to me it's useless, it's like we can also add "the contract should be deployed"

Suggested change

	/// - Feeds are set in the correct order.
	/// - Decimals passed as argument are correct.

[Rubilmax]

I also feel lik this

[MerlinEgalite]

it's like we can also add "the contract should be deployed"

That's different. it reminds deployers what they should care about those params and it acknowledges to auditors that we don't check it (but we don't forget that this is important for a good setup).

It's closer to your mom saying "you should put your seatbelt". Ofc you know that you should do it but forgetting once could kill you.

PS: if we can reduce by 1% the hundreds of issues raised during the competition I would be happy

[MathisGD]

it reminds deployers what they should care about those params

but it's always like that no? in which contract don't we care about the constructor parameter.

PS: if we can reduce by 1% the hundreds of issues raised during the competition I would be happy

what report does it prevent (honestly idk)?

[MerlinEgalite]

In other contracts we make sure we list the assumptions or do the check though.

what report does it prevent (honestly idk)?

• lack of sanity checks
• decimals set as input can be incorrect
• feeds might not give the expected output
• ...

[MathisGD]

still in favor of removing this but it's not a big deal

/// - Feeds are set in the correct order.
/// - Decimals passed as argument are correct.