Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename onlyUpdater -> onlyUpdaterRole #93

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Rename onlyUpdater -> onlyUpdaterRole #93

merged 2 commits into from
Nov 3, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite requested review from Rubilmax and a team November 2, 2023 13:05
@MerlinEgalite MerlinEgalite self-assigned this Nov 2, 2023
@MerlinEgalite MerlinEgalite requested review from Jean-Grimal and removed request for a team November 2, 2023 13:05
@Rubilmax Rubilmax changed the title Rename onlyUpdater -> onlyUpdateRole Rename onlyUpdater -> onlyUpdaterRole Nov 2, 2023
Rubilmax
Rubilmax approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think error messages could be shortened but I'm not blocking ^^

@MerlinEgalite MerlinEgalite merged commit c04ef75 into cantina-review Nov 3, 2023
@MerlinEgalite MerlinEgalite deleted the fix/only-updater-modifier-114 branch November 3, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@julien-devatom julien-devatom Awaiting requested review from julien-devatom

Assignees

@MerlinEgalite MerlinEgalite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MerlinEgalite @Rubilmax @Jean-Grimal