Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(events): rename UrdCreated event params #99

Merged
merged 2 commits into from
Nov 7, 2023
Merged

refactor(events): rename UrdCreated event params #99

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff31a5
refactor(events): rename `UrdCreated` event params
julien-devatom Nov 6, 2023
978669f
refactor(events): clarify event params naming
julien-devatom Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/libraries/EventsLib.sol
View file
Open in desktop
julien-devatom marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ library EventsLib {
event RootProposed(bytes32 indexed newRoot, bytes32 indexed newIpfsHash);

/// @notice Emitted when a merkle tree distribution timelock is set.
/// @param timelock The new merkle timelock.
event TimelockSet(uint256 timelock);
/// @param newTimelock The new merkle timelock.
event TimelockSet(uint256 newTimelock);

/// @notice Emitted when a merkle tree updater is added or removed.
/// @param rootUpdater The merkle tree updater.
Expand All @@ -41,18 +41,18 @@ library EventsLib {
/// @notice Emitted when a new URD is created.
/// @param urd The address of the newly created URD.
/// @param caller The address of the caller.
/// @param owner The address of the URD owner.
/// @param timelock The URD timelock.
/// @param root The URD's initial merkle root.
/// @param ipfsHash The URD's initial ipfs hash.
/// @param initialOwner The address of the URD owner.
/// @param initialTimelock The URD timelock.
/// @param initialRoot The URD's initial merkle root.
/// @param initialIpfsHash The URD's initial ipfs hash.
/// @param salt The salt used for CREATE2 opcode.
event UrdCreated(
address indexed urd,
address indexed caller,
address indexed owner,
uint256 timelock,
bytes32 root,
bytes32 ipfsHash,
address indexed initialOwner,
uint256 initialTimelock,
bytes32 initialRoot,
bytes32 initialIpfsHash,
bytes32 salt
);
}