Gui: Refactor PreferencePackManager & DlgPreferencePackManagementImp #1532
CI_master.yml
on: push
Prepare
/
Prepare
6s
MacOS_13_Conda_Apple
/
Build
15m 1s
Ubuntu_20-04
/
Build
13m 47s
Ubuntu_22-04_Conda
/
Build
14m 58s
Windows
/
Build
24m 38s
Lint
/
Lint
3m 13s
Ubuntu_22-04_Conda_Qt6
/
Build
17m 7s
WrapUp
/
WrapUp
5s
Annotations
11 errors and 60 warnings
Lint / Lint
Process completed with exit code 2.
|
Lint / Lint
Process completed with exit code 2.
|
Lint / Lint:
src/Gui/PreferencePackManager.h#L234
unknown type name 'Q_DECLARE_METATYPE'
|
Lint / Lint:
src/Gui/PreferencePackManager.h#L234
no member named 'TemplateFile' in 'Gui::PreferencePackManager'
|
Lint / Lint:
src/Gui/PreferencePackManager.h#L234
expected ';' after top level declarator
|
Lint / Lint
Process completed with exit code 1.
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.cpp#L29
'ui_DlgPreferencePackManagement.h' file not found [clang-diagnostic-error]
|
Lint / Lint:
src/Gui/PreferencePackManager.h#L234
unknown type name 'Q_DECLARE_METATYPE' [clang-diagnostic-error]
|
Lint / Lint:
src/Gui/PreferencePackManager.h#L234
no member named 'TemplateFile' in 'Gui::PreferencePackManager' [clang-diagnostic-error]
|
Lint / Lint:
src/Gui/PreferencePackManager.h#L234
expected ';' after top level declarator [clang-diagnostic-error]
|
Lint / Lint
Process completed with exit code 1.
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.cpp#L68
variable 'installedPacks' is not initialized [cppcoreguidelines-init-variables]
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.cpp#L110
variable 'items' is not initialized [cppcoreguidelines-init-variables]
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.cpp#L197
suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.h#L35
nested namespaces can be concatenated [modernize-concat-nested-namespaces]
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.h#L48
class 'DlgPreferencePackManagementImp' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
Lint / Lint:
src/Gui/DlgPreferencePackManagementImp.h#L54
single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor]
|
Lint / Lint:
src/Gui/PreferencePackManager.cpp#L183
statement should be inside braces [readability-braces-around-statements]
|
Lint / Lint:
src/Gui/PreferencePackManager.cpp#L187
statement should be inside braces [readability-braces-around-statements]
|
Lint / Lint:
src/Gui/PreferencePackManager.cpp#L322
statement should be inside braces [readability-braces-around-statements]
|
Lint / Lint:
src/Gui/PreferencePackManager.cpp#L324
statement should be inside braces [readability-braces-around-statements]
|
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Ubuntu_22-04_Conda / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Ubuntu_22-04_Conda / Build
/home/runner/miniconda3/lib/python3.12/site-packages/conda/base/context.py:198: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3.
To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels:
conda config --add channels defaults
For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html
deprecated.topic(
|
Ubuntu_22-04_Conda / Build
The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
|
Ubuntu_22-04_Conda / Build
/home/runner/miniconda3/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead.
action(self, namespace, argument_values, option_string)
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(377): conda version: 24.9.2
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(378): conda-libmamba-solver version: 24.9.0
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(379): libmambapy version: 1.5.9
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(380): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(381): Command: ['/home/runner/miniconda3/condabin/mamba', 'create', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 729494 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Linux/6.5.0-1025-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 3360554d82975fc1… → 3360554d82975fc1…
|
Ubuntu_22-04_Conda / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
MacOS_13_Conda_Apple / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
MacOS_13_Conda_Apple / Build
/Users/runner/miniconda3/lib/python3.12/site-packages/conda/base/context.py:198: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3.
To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels:
conda config --add channels defaults
For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html
deprecated.topic(
|
MacOS_13_Conda_Apple / Build
The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
|
MacOS_13_Conda_Apple / Build
/Users/runner/miniconda3/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead.
action(self, namespace, argument_values, option_string)
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(377): conda version: 24.9.2
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(378): conda-libmamba-solver version: 24.9.0
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(379): libmambapy version: 1.5.9
INFO conda.conda_libmamba_solver.solver:_log_info(380): Target prefix: '/Users/runner/work/FreeCAD/FreeCAD/.conda/freecad'
INFO conda.conda_libmamba_solver.solver:_log_info(381): Command: ['/Users/runner/miniconda3/condabin/mamba', 'create', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 0 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Darwin/23.6.0 OSX/14.7.1 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 5fef5ecd58e910a9… → 5fef5ecd58e910a9…
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 729494 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Darwin/23.6.0 OSX/14.7.1 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 3360554d82975fc1… → 3360554d82975fc1…
|
MacOS_13_Conda_Apple / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Ubuntu_22-04_Conda_Qt6 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Ubuntu_22-04_Conda_Qt6 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Ubuntu_22-04_Conda_Qt6 / Build
/home/runner/miniconda3/lib/python3.12/site-packages/conda/base/context.py:198: FutureWarning: Adding 'defaults' to channel list implicitly is deprecated and will be removed in 25.3.
To remove this warning, please choose a default channel explicitly with conda's regular configuration system, e.g. by adding 'defaults' to the list of channels:
conda config --add channels defaults
For more information see https://docs.conda.io/projects/conda/en/stable/user-guide/configuration/use-condarc.html
deprecated.topic(
|
Ubuntu_22-04_Conda_Qt6 / Build
The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
|
Ubuntu_22-04_Conda_Qt6 / Build
/home/runner/miniconda3/lib/python3.12/argparse.py:2006: FutureWarning: `remote_definition` is deprecated and will be removed in 25.9. Use `conda env create --file=URL` instead.
action(self, namespace, argument_values, option_string)
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(377): conda version: 24.9.2
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(378): conda-libmamba-solver version: 24.9.0
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(379): libmambapy version: 1.5.9
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(380): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(381): Command: ['/home/runner/miniconda3/condabin/mamba', 'create', '--prefix', '.conda/freecad', '--file', 'conda/conda-env-qt6.yaml']
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(265): Download 729494 bytes {'User-Agent': 'conda/24.9.2 requests/2.32.3 CPython/3.12.7 Linux/6.5.0-1025-azure ubuntu/22.04.5 glibc/2.35 solver/libmamba conda-libmamba-solver/24.9.0 libmambapy/1.5.9', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(432): Apply 0 patches 3360554d82975fc1… → 3360554d82975fc1…
|
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release.
A separate `actions/cache/restore` step should be used instead.
See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
Lint-12070734499-Logs
|
9.14 KB |
|
MacOS_13_Conda_Apple-12070734499-Logs
|
45 KB |
|
Prepare-12070734499-Logs
|
6.41 KB |
|
Ubuntu_20-04-12070734499-Logs
|
184 KB |
|
Ubuntu_22-04_Conda-12070734499-Logs
|
241 KB |
|
Ubuntu_22-04_Conda-Qt6-12070734499-Logs
|
239 KB |
|
Ubuntu_22-04_Conda-Qt6-12070734499-report.md
|
3.79 KB |
|
Windows-12070734499-Logs
|
1.65 MB |
|