Gui: Refactor PreferencePackManager & DlgPreferencePackManagementImp #1532
Annotations
11 errors and 20 warnings
|
Codespell
Process completed with exit code 2.
|
|
Cpplint
Process completed with exit code 2.
|
|
Clazy:
src/Gui/PreferencePackManager.h#L234
unknown type name 'Q_DECLARE_METATYPE'
|
|
Clazy:
src/Gui/PreferencePackManager.h#L234
no member named 'TemplateFile' in 'Gui::PreferencePackManager'
|
|
Clazy:
src/Gui/PreferencePackManager.h#L234
expected ';' after top level declarator
|
|
Clazy
Process completed with exit code 1.
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.cpp#L29
'ui_DlgPreferencePackManagement.h' file not found [clang-diagnostic-error]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.h#L234
unknown type name 'Q_DECLARE_METATYPE' [clang-diagnostic-error]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.h#L234
no member named 'TemplateFile' in 'Gui::PreferencePackManager' [clang-diagnostic-error]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.h#L234
expected ';' after top level declarator [clang-diagnostic-error]
|
|
Clang-tidy
Process completed with exit code 1.
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
|
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L3130
Pass small and trivially-copyable type by value (const long &) [-Wclazy-function-args-by-value]
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.cpp#L68
variable 'installedPacks' is not initialized [cppcoreguidelines-init-variables]
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.cpp#L110
variable 'items' is not initialized [cppcoreguidelines-init-variables]
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.cpp#L197
suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.h#L35
nested namespaces can be concatenated [modernize-concat-nested-namespaces]
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.h#L48
class 'DlgPreferencePackManagementImp' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
|
|
Clang-tidy:
src/Gui/DlgPreferencePackManagementImp.h#L54
single-argument constructors must be marked explicit to avoid unintentional implicit conversions [google-explicit-constructor]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.cpp#L183
statement should be inside braces [readability-braces-around-statements]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.cpp#L187
statement should be inside braces [readability-braces-around-statements]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.cpp#L322
statement should be inside braces [readability-braces-around-statements]
|
|
Clang-tidy:
src/Gui/PreferencePackManager.cpp#L324
statement should be inside braces [readability-braces-around-statements]
|
Loading