Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect when transfer complete #593

Closed
shreeThaanuTw opened this issue Feb 27, 2023 · 2 comments
Closed

Disconnect when transfer complete #593

shreeThaanuTw opened this issue Feb 27, 2023 · 2 comments
Labels
BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet
Milestone

Comments

@shreeThaanuTw
Copy link

Describe the bug
Disconnect connection must happen when transfer complete and UI responds happen in iOS.

Expected behavior
Disconnect connection happens when transfer complete.

Actual behavior
Disconnect connection not happening.

Screenshots
If applicable, add screenshots to help explain your problem.

Add the screenshot of the profile page with commit id

Smartphone (please complete the following information):

  • Wallet Device: [e.g. iPhone6]

    • Phone make/model: [e.g. :Vivo Y73]
    • OS: [e.g. iOS8.1]
    • BLE version : [e.g. 4.2]
  • Verifier Device: [e.g. iPhone6]

    • Phone make/model: [e.g. :Vivo Y73]
    • OS: [e.g. iOS8.1]
    • BLE version : [e.g. 4.2]
  • Inji app version: [e.g 0.3.0]

  • Mimoto version: [e.g 1.2.x]

  • MOSIP Version: [e.g. 1.2.1]

Where does the issue occur: Wallet/Verifier?

Logs of wallet and verifier:

Additional context
Add any other context about the problem here.

@shreeThaanuTw shreeThaanuTw added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet labels Feb 27, 2023
@ravikp ravikp added BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism labels Feb 28, 2023
@ravikp ravikp added this to the 28th Feb 23 milestone Feb 28, 2023
@Alka1703
Copy link
Contributor

The following PRs implements disconnection of the verifier and wallet after the VC is transferred and accepted/rejected on the iOS side.
PR for mosip/tuvali: mosip/tuvali#28
PR for mosip/inji: #595, #597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

@ravikp ravikp added enhancement New feature or request and removed bug Something isn't working labels Mar 1, 2023
@ravikp
Copy link
Contributor

ravikp commented Mar 1, 2023

Closing since issue as it was delivered.

@ravikp ravikp closed this as completed Mar 1, 2023
@ravikp ravikp moved this from Merged to Closed in MOSIP Inji issues tracking Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet
Projects
Status: Closed
Development

No branches or pull requests

4 participants