Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sections/islands in the menu. (backport #23308) #23310

Open
wants to merge 1 commit into
base: release/v133
Choose a base branch
from
Open

Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sections/islands in the menu. (backport #23308) #23310

wants to merge 1 commit into from
+7 −3

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Fixed tableView margins and section headers height

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #23308 done by [Mergify](https://mergify.com).

@dicarobinho @mergify
Bugfix FXIOS-10569 ⁃ [Menu] Fix the margin and Padding for the sectio…
0b61555 
…ns/islands in the menu. (#23308)

FXIOS-10569 #23140 ⁃ [Menu Redesign] Fix the margin and Padding for the sections/islands in the menu.

(cherry picked from commit 97d6161)
@mergify mergify bot requested a review from a team as a code owner November 22, 2024 10:53
@mergify mergify bot requested review from mdotb-moz and removed request for a team November 22, 2024 10:53
@mergify mergify bot mentioned this pull request Nov 22, 2024
Merged
6 tasks
@dicarobinho dicarobinho added the weekly-release Tagging backports for rapid release label Nov 22, 2024
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 31.99%
📖 Edited 2 files
📖 Created 0 files

MenuKit: Coverage: 40.52

File Coverage
MenuMainView.swift 51.61% ✅
MenuTableView.swift 44.19% ⚠️

Generated by 🚫 Danger Swift against 0b61555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdotb-moz mdotb-moz Awaiting requested review from mdotb-moz mdotb-moz is a code owner automatically assigned from mozilla-mobile/fxios-eng

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobiletest-ci-bot @dicarobinho