Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Update to Node.js v18 for test-dev CI #37604

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jun 16, 2023

The developer scripts currently use Node v14 on the test-dev CI. However, now that the pull request #37173 is completed, we should switch to using Node v18 for consistency. It runs the yarn install step.

This should unblock dependencies updates such as #37349 and others as they require Node >=16.

@ZeeshanTamboli ZeeshanTamboli added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels Jun 16, 2023
@mui-bot
Copy link

mui-bot commented Jun 16, 2023

Netlify deploy preview

https://deploy-preview-37604--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 8165333

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review June 16, 2023 07:04
@ZeeshanTamboli ZeeshanTamboli requested a review from a team June 16, 2023 07:04
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Use Node v18 for test-dev CI [core] Update to Node v18 for test-dev CI Jun 16, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [core] Update to Node v18 for test-dev CI [core] Update to Node.js v18 for test-dev CI Jun 16, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit fd115e6 into mui:master Jun 16, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the use-node-18-in-test-dev-ci branch June 16, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants