Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Move the opening logic to the range fields #16175

Draft
wants to merge 261 commits into
base: master
Choose a base branch
from

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 14, 2025

In this PR

  • Move the opening logic of the range pickers to be inside the field components
  • Change the opening logic of the single input fields to use an end adornment
  • Change the role and lifecycle of the popper to act like a dialog on desktop range pickers with single input fields (but keep the tooltip behavior for desktop range pickers with multi input fields)

Follow up

  • Make the single input fields the default field for the range pickers
  • Rename the single input fields from SingleInputXXXField to XXXField to show they are the recommended approach? (and keep SingleInputXXXField components until v9 but deprecated)
  • Improve the keyboard navigation on the Date Range Calendar to have a preview when like on hover

Extracted PRs

@flaviendelangle flaviendelangle force-pushed the multi-input-opening-logic branch from b62852d to 2663c38 Compare January 31, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants