-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to Google in UI #7557
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, all discussions resolved
@pinkisemils I believe you're looking for this line:
Do you want me to push a commit? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadVPN/Coordinators/Settings/APIAccess/Models/AccessMethodViewModel.swift
line 227 at r2 (raw file):
If you are not connected to our VPN, then the Encrypted DNS proxy will use your own non-VPN IP \ when connecting. The DoH servers are hosted by one of the following providers: Quad9, Cloudflare.
nit: not consistent with the desktop/android string. Is that intentional? Otherwise we should probably align them 🙂
Quad9, Cloudflare
vs. Quad9 or Cloudflare
Code quote:
Quad9, Cloudflare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 21 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
fbc6f41
to
a8a41ad
Compare
I did a bad by updating the changelog and removing the Google resolvers from the
mullvda-encrypted-dns-proxy
. Now I'm cleaning it up and removing it from the UI too. I couldn't find any reference to Google in the android codebase, am I ooking in the right places @albin-mullvad ?This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)