Fix ability to move server-side vehicles that are far away from the player

[MegadreamsBE]

fixes #3389

Adds extra checks to ensure that players cannot use setElementPosition client-side to move vehicles that are far away from them. Essentially closes loopholes that made it possible for players to become the syncer of said vehicles.

[Nico8340]

Looks good to me 🚀

[Lpsd]

I think it would be good to make MAX_CONTACT_SYNC_RADIUS value configurable via the Lua API

[MegadreamsBE]

I think it would be good to make MAX_CONTACT_SYNC_RADIUS value configurable via the Lua API

In that case it'd probably be better to link it with the syncer radius and make them configurable together. On its own there's not much of a reason to be able to configure this radius

EDIT: Adds the ability to disable it which is actually pretty useful, I stand corrected and thus implemented it

[Nico8340]

Looks good 🎉

[MegadreamsBE]

I think it would be good to make MAX_CONTACT_SYNC_RADIUS value configurable via the Lua API

Added a configurable server setting for it. You can configure it as follows during runtime:
setServerConfigSetting('vehicle_contact_sync_radius', 30)

Which should satisfy this.

[haron4igg]

Just to be sure...

If client will set position for vehicle locally - will car appear locally to him?
If so - when player will enter the car - it will be forcely synced to new location anyway?

[MegadreamsBE]

Just to be sure...

If client will set position for vehicle locally - will car appear locally to him? If so - when player will enter the car - it will be forcely synced to new location anyway?

If you're not the syncer, even if the vehicle appears to be near you on your client, you cannot enter it. Instead attempting to the enter the vehicle will reset its position to the position stored on the server. It has always been like this and the PR does not change that.

[Lpsd]

LGTM!

[Lpsd]

Thanks for this PR, please update https://wiki.multitheftauto.com/wiki/SetServerConfigSetting and https://wiki.multitheftauto.com/wiki/Server_mtaserver.conf where necessary.