-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add COSE structure extensions that allow use of predefined cryptographic backends + an OpenSSL based backend. #13
Conversation
Pull Request Test Coverage Report for Build 9601666399Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9727733938Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! It's nice to finally get an actual cipher implementation. As always, here's my list of pedantic comments.
Pull Request Test Coverage Report for Build 9767273749Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 10239234233Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Oh, before I forget: When you're working on the documentation, could you also update the README, specifically the section about the COSE cipher? To do so, you can change the crate-level documentation in |
Aside from fixing the links in the documentation and running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Falko Galperin <[email protected]>
Co-authored-by: Falko Galperin <[email protected]>
Co-authored-by: Falko Galperin <[email protected]>
23159b4
to
e3e65eb
Compare
This PR will add cipher implementations based on the
openssl
crate, which binds to the nativeopenssl
library.1Currently, only one algorithm per "type" is currently supported (ECDSA for signing, AES-GCM for encrypting, AES-Key-Wrap for key distribution, HMAC for message authentication codes).
In order to not inflate this PR further, other algorithms and a potential RustCrypto based backend are probably better added in separate, smaller PRs.
Footnotes
Better Nate than lever! ↩