Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e tests on merge to main #91

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Run e2e tests on merge to main #91

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd11bb2
initial commit
rylew1 Nov 18, 2024
9632c14
add noisy comment for reusable workflows
rylew1 Nov 18, 2024
d0b58a7
update workflow name
rylew1 Nov 18, 2024
6b98332
allow inputs
rylew1 Nov 18, 2024
6e55d00
update with variables to use inputs
rylew1 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/ci-app-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: CI app E2E tests on main

on:
push:
branches:
- main
workflow_dispatch:
inputs:
service_endpoint:
description: "The service endpoint URL for the E2E tests"
required: true
type: string
app_name:
description: "The application name"
required: true
type: string

jobs:
call-e2e-tests:
name: " " # GitHub UI is noisy when calling reusable workflows, so use whitespace for name to reduce noise
uses: ./.github/workflows/e2e-tests.yml
with:
service_endpoint: ${{ inputs.service_endpoint || 'http://app-dev-2093346449.us-east-1.elb.amazonaws.com' }}
app_name: ${{ inputs.app_name || 'app' }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorenyu - I think we need to have this workflow on the default branch / main to run it manually

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a way to run it manually:

  1. Temporarily add a pull_request trigger to the workflow. This will cause the workflow to run once on your branch.
  2. Remove the pull_request trigger from the workflow.
  3. Now you should be able to manually using the GitHub CLI via gh workflow run ci-app-e2e-tests.yml --ref rylew/run-e2e-on-merge-to-main

Copy link
Author

@rylew1 rylew1 Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, haven't used the cli yet. I will hold off on this for now though.

Will the CLI paradigm allow for a service_endpoint to be passed in? - I see it's kind of unclear in the current paradigm - seems like the only way to set it up on template-infra now would be to have the user potentially hardcode their dev environment and app name

Loading