Fixes #488: Add logging to the driver config #494
Conversation
There was a problem hiding this comment.
Hi @igorvoltaic thank you so much for the contribution, can yo please answer to my question?
| @@ -39,7 +40,7 @@ class Neo4jService(private val config: Neo4jSinkConnectorConfig): | |||
| private val transactionConfig: TransactionConfig | |||
|
|
|||
| init { | |||
| val configBuilder = Config.builder() | |||
| val configBuilder = Config.builder().withLogging(Logging.slf4j()) | |||
There was a problem hiding this comment.
why this approach and not the same of the other PR?
There was a problem hiding this comment.
Hi Andrea! Thanks for taking your time and looking at my PRs! Like I've said in the support ticket that's only because I'm not Java/Kotlin guy and wanted your experienced look at these two approaches. I saw you mentioned you liked the other approach, I can definitely port it to this PR. Also I wasn't really sure which is the best way because offical neo4j driver API docs literally say: This logging method is the preferred one and relies on the SLF4J implementation available in the classpath or modulepath
Also it worth mentioning that ideally the connector logs should be managed in the similar manner the official docs suggests it. Where they could be configured via container env variables picked up by native confluent kafka-connect env tools
log4j.logger.org.apache.kafka.connect.runtime.WorkerSinkTask=DEBUG
log4j.logger.org.apache.kafka.connect=DEBUG
Please let me know if you still want to port #493? Thanks again!
There was a problem hiding this comment.
If you look at the code of the java driver:
It uses the same API that you used in the other PR.
So maybe I misunderstood the goal of this and other PR. Do you want to provide a config option for the log level of the java driver? Or?
There was a problem hiding this comment.
Thanks for the link! Yeah, I do, I've ported the PR
There was a problem hiding this comment.
@igorvoltaic please consider to apply all my comments to branch 4.1 in particular in Neo4jConnectorConfig.kt as requested here:
Branch 4.1 contains the code of Kafka Connect Neo4j Connecto 2.0.0 that we released two weeks ago, and is the place where al new features will be implemented. In order to use this cool contribution please port these (with the requested changes) to branch 4.1
Thank you so much!!!
kafka-connect-neo4j/src/main/kotlin/streams/kafka/connect/sink/Neo4jSinkConnectorConfig.kt
Outdated
Show resolved
Hide resolved
kafka-connect-neo4j/src/main/kotlin/streams/kafka/connect/sink/Neo4jSinkConnectorConfig.kt
Outdated
Show resolved
Hide resolved
kafka-connect-neo4j/src/main/kotlin/streams/kafka/connect/sink/Neo4jSinkConnectorConfig.kt
Outdated
Show resolved
Hide resolved
kafka-connect-neo4j/src/main/kotlin/streams/kafka/connect/sink/Neo4jSinkConnectorConfig.kt
Show resolved
Hide resolved
…/Neo4jSinkConnectorConfig.kt Co-authored-by: Andrea Santurbano <[email protected]>
…/Neo4jSinkConnectorConfig.kt Co-authored-by: Andrea Santurbano <[email protected]>
…/Neo4jSinkConnectorConfig.kt Co-authored-by: Andrea Santurbano <[email protected]>
…/Neo4jSinkConnectorConfig.kt Co-authored-by: Andrea Santurbano <[email protected]>
igorvoltaic
changed the title
|
Implemented in #502, version 4.1 |
Fixes #488
Suggestion to change the log level of Neo4j driver
Proposed Changes
A brief list of proposed changes in order to fix the issue: