Fixes #488: Add logging to the driver config (4.1) #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igorvoltaic yes please. |
Yes, sent the message |
conker84
suggested changes
Oct 1, 2021
Comment on lines
38
to
49
| enum class DriverLogLevel(var level: Level) { | ||
| ERROR(Level.SEVERE), | ||
| INFO(Level.INFO), | ||
| WARN(Level.WARNING), | ||
| DEBUG(Level.FINE), | ||
| TRACE(Level.FINEST); | ||
|
|
||
| // Return 'INFO' if user supplied incorrect level name | ||
| companion object { | ||
| fun from(type: String?): DriverLogLevel = values().find { it.name == type } ?: INFO | ||
| } | ||
| } |
There was a problem hiding this comment.
This means that we need to document the mapping of the log level, moreover if something change in the driver logging name we need to update the code, can you please just do as asked here?
|
Hey @conker84! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488
Suggestion to change the log level of Neo4j driver
Proposed Changes
A brief list of proposed changes in order to fix the issue: