Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DROP DATABASE name CASCADE ALIASES #1036

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Hunterness
Copy link
Collaborator

@Hunterness Hunterness commented Sep 3, 2024

Companion Pr to neo4j/docs-operations#1805, should probably wait for that to go in.

Documenting https://github.com/neo-technology/neo4j/pull/26465, needs to wait until that has been merged.

@mnd999 mnd999 self-assigned this Sep 4, 2024
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@JPryce-Aklundh JPryce-Aklundh merged commit 3de159e into neo4j:dev Sep 25, 2024
5 checks passed
@@ -103,8 +103,21 @@ label:new[]
DROP [COMPOSITE] DATABASE ... [RESTRICT \| CASCADE ALIAS[ES]]
----

| Added the ability to drop any database aliases, that would otherwise block the deletion of the database, at the same time as the deletion of the database.
| Added the ability to drop database aliases while deleting a database.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Added the ability to drop database aliases while deleting a database.
| Added the ability to drop database aliases while dropping a database.

maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though I guess we are already pretty inconsistent if we write drop or delete 🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right - we need to decide on which to use and stick with it. Personally I think we should use drop because that is what the command is called (otherwise I definitely would have preferred "delete"). I will bring this up with my Ops Manual colleagues and take a decision.

Comment on lines 110 to 120
a|
label:functionality[]
label:new[]
[source, cypher, role=noheader]
----
LOAD CSV FROM 'azb://azb-account/azb-container/artists.csv' AS row
MERGE (a:Artist {name: row[1], year: toInteger(row[2])})
RETURN a.name, a.year
----

| Extension of the xref:clauses/load-csv.adoc#azure-cloud-storage[LOAD CSV] clause to allow loading CSV files from Azure Cloud Storage URIs.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels weird that this is added as part of this PR...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasnt - it was added here #1008
It appeared in this PR because I had to resolve a conflict

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because you pull-merged instead of rebased XD

JPryce-Aklundh added a commit to JPryce-Aklundh/docs-cypher that referenced this pull request Sep 26, 2024
Companion Pr to neo4j/docs-operations#1805,
~~should probably wait for that to go in.~~

Documenting neo-technology/neo4j#26465, ~~needs
to wait until that has been merged.~~

---------

Co-authored-by: Jens Pryce-Åklundh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants