Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DROP DATABASE name CASCADE ALIASES #1036

Merged
merged 3 commits into from
Sep 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,18 @@ REMOVE n[$prop]
----
| Added the ability to dynamically reference properties in xref:clauses/set.adoc#set-dynamically-a-property[SET] and xref:clauses/remove.adoc#remove-remove-a-property-dynamically[REMOVE] clauses.

a|
Hunterness marked this conversation as resolved.
Show resolved Hide resolved
label:functionality[]
label:new[]
Hunterness marked this conversation as resolved.
Show resolved Hide resolved
[source, cypher, role=noheader]
----
DROP [COMPOSITE] DATABASE ... [RESTRICT \| CASCADE ALIAS[ES]]
----

| Added the ability to drop database aliases while deleting a database.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Added the ability to drop database aliases while deleting a database.
| Added the ability to drop database aliases while dropping a database.

maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though I guess we are already pretty inconsistent if we write drop or delete 🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right - we need to decide on which to use and stick with it. Personally I think we should use drop because that is what the command is called (otherwise I definitely would have preferred "delete"). I will bring this up with my Ops Manual colleagues and take a decision.

This will affect local database aliases targeting the database and constituent database aliases belonging to the composite database.
For more information, see link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-administration/standard-databases/delete-databases/#delete-databases-with-aliases[Delete a database with local database aliases targeting it] and link:{neo4j-docs-base-uri}/operations-manual/{page-version}/database-administration/composite-databases/delete-composite-databases/#composite-databases-delete-with-aliases[Delete a composite database with constituent database aliases].

a|
label:functionality[]
label:new[]
Expand Down
Loading