-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move util/launcher/src/migrate.rs
to an independent crate
#4235
Move util/launcher/src/migrate.rs
to an independent crate
#4235
Conversation
Fixing cargo clippy... |
Will this PR include moving SharedPackage and SharedBuilder to ckb-shared? |
No, this PR only move "Moving |
What problem does this PR solve?
This PR want to move
util/launcher/src/migrate.rs
related module into an independent crate, this will help resolve ckb's dependency cycles issue.In the production build:
ckb-launcher
needckb-chain
.But in
dev
build:ckb-chain
needckb-launcher
'sSharedPackage
andSharedBuilder
.If we move
util/launcher/src/migrate.rs
to an independent crate, thenSharedPackage
andSharedBuilder
can be moved tockb-shared
. Then we won't needckb-launcher
to buildshared
in ckb's unit tests anymore.On
develop
branch:After this PR:
What's Changed:
Related changes
util/launcher/src/migrate.rs
related module into an independent crate (ckb-migrate
)Check List
Tests
Side effects
Release note