-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break ckb-launcher
and ckb-chain
's cycle dependency by moving SharedPackage
and SharedBuilder
from ckb-launcher
to ckb-shared
#4236
Merged
quake
merged 47 commits into
nervosnetwork:develop
from
eval-exec:exec/break-ckb-launcher-cycle-deps
Nov 21, 2023
Merged
Break ckb-launcher
and ckb-chain
's cycle dependency by moving SharedPackage
and SharedBuilder
from ckb-launcher
to ckb-shared
#4236
quake
merged 47 commits into
nervosnetwork:develop
from
eval-exec:exec/break-ckb-launcher-cycle-deps
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eval EXEC <[email protected]>
Signed-off-by: Eval EXEC <[email protected]>
eval-exec
changed the title
Break
Break Nov 20, 2023
ckb-launcher
and ckb-chain
's cycle dependencyckb-launcher
and ckb-chain
's cycle dependency, move SharedPackage
and SharedBuilder
from ckb-launcher
to ckb-shared
eval-exec
changed the title
Break
Break Nov 20, 2023
ckb-launcher
and ckb-chain
's cycle dependency, move SharedPackage
and SharedBuilder
from ckb-launcher
to ckb-shared
ckb-launcher
and ckb-chain
's cycle dependency by moving SharedPackage
and SharedBuilder
from ckb-launcher
to ckb-shared
quake
requested changes
Nov 20, 2023
Co-authored-by: Quake Wang <[email protected]>
eval-exec
requested review from
quake,
chenyukang,
zhangsoledad,
EthanYuan and
driftluo
November 20, 2023 08:10
quake
approved these changes
Nov 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR is based on #4235
In the
develop
branch,ckb-chain
's unit test needckb-launcher
, andckb-launcher
needckb-chain
, this PR want to moveSharedPackage
andSharedBuilder
fromckb-launcher
tockb-shared
, thenckb-chain
won't needckb-launcher
anymore, this will break the cycle dependencies:before:
After this PR:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note