NetRpcImpl::get_peers return Remoteaddress.addresses dedup
#4795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eval-exec
requested review from
doitian and
driftluo
and removed request for
a team
quake
reviewed
Jan 24, 2025
rpc/src/module/net.rs
Outdated
| @@ -586,7 +587,7 @@ impl NetRpc for NetRpcImpl { | |||
| .connected_peers() | |||
| .iter() | |||
| .map(|(peer_index, peer)| { | |||
| let mut addresses = vec![&peer.connected_addr]; | |||
| let mut addresses: HashSet<_> = vec![&peer.connected_addr].into_iter().collect(); | |||
There was a problem hiding this comment.
no need to create vec and convert to hashet, we may use the iterator to collect directly:
let addresses: HashSet<_> = std::iter::once(peer.connected_addr).chain(peer.listened_addrs.iter()).collect();
Signed-off-by: Eval EXEC <[email protected]>
eval-exec
force-pushed
the
exec/get-peers-dedup
branch
from
dc8b4ec to
9508269
Compare
driftluo
approved these changes
Jan 24, 2025
doitian
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
get_peersRPC returnedRemoteAddress.addressesshouldn't contains duplicateMultiAddr.Related changes
NetRpcImpl::get_peers, useHashSetto remove duplicateMultiAddr.Check List
Tests
Side effects
Release note