Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/eslint require await #591

Closed
wants to merge 3 commits into from
Closed

Feat/eslint require await #591

wants to merge 3 commits into from

Conversation

r-marques
Copy link
Member

Description

  • eslint will now throw a linter error when declaring a function as async when there is no await inside

Is this PR related with an open issue?

Closes #557

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

@r-marques r-marques requested review from a team as code owners October 4, 2023 10:49
@r-marques r-marques changed the base branch from main to develop October 4, 2023 10:49
@r-marques r-marques marked this pull request as draft October 4, 2023 11:29
@r-marques r-marques closed this Oct 5, 2023
@r-marques r-marques deleted the feat/eslint-require-await branch October 5, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable eslint require-await rule
1 participant
@r-marques