Feat/eslint require await

.eslintrc

@@ -10,7 +10,10 @@
          "argsIgnorePattern": "^_",
          "varsIgnorePattern": "^_",
          "caughtErrorsIgnorePattern": "^_"
-    }]
+    }],
+    "require-await":"error"
   },
   "ignorePatterns": ["test/resources/proxy-poc/*.js"]
 }
+
+// TODO: check https://dev.to/qpwo/most-useful-eslint-rules-for-networking-code-asyncawaitpromises-1mg4

integration/nevermined/Assets.test.ts

@@ -310,7 +310,7 @@ describe('Assets', () => {
       assert.equal(metadata.attributes.curation.numVotes, 1 + 2)
     })
 
-    it('new rating must be between 0 and 1', async () => {
+    it('new rating must be between 0 and 1', () => {
       // Trying to add a vote with a rating out of range
 
       nevermined.assets
@@ -595,7 +595,7 @@ describe('Assets', () => {
       assert.equal(resolvedDDO._nvm.versions.length, 1)
     })
 
-    it('dont resolve from the DIDRegistry', async () => {
+    it('do not resolve from the DIDRegistry', () => {
       rejects(nevermined.assets.resolve(offchainDID, DIDResolvePolicy.MetadataAPIFirst))
     })
   })

integration/nevermined/ContractEvent.test.ts

@@ -22,7 +22,7 @@ describe('ContractEvent', () => {
     executeTransaction = () => nevermined.keeper.dispenser.requestTokens(1, account.getId())
   })
 
-  it('should get a ContractEvent instance', async () => {
+  it('should get a ContractEvent instance', () => {
     assert.instanceOf(nevermined.keeper.token.events, ContractEvent)
   })
 

integration/nevermined/MetaTx.test.ts

@@ -38,7 +38,7 @@ describe.skip('MetaTx test with nfts', () => {
     await nevermined.keeper.nftUpgradeable.grantOperatorRole(artist.getId(), nftContractOwner)
   })
 
-  describe('with default token', async () => {
+  describe('with default token', () => {
     before(async () => {
       const metadata = getMetadata(Math.random())
       metadata.userId = payload.sub

integration/nevermined/NFT.test.ts

@@ -27,7 +27,7 @@ describe('Nfts operations', () => {
     payload = decodeJwt(config.marketplaceAuthToken)
   })
 
-  describe('with default token', async () => {
+  describe('with default token', () => {
     before(async () => {
       const metadata = getMetadata()
       metadata.userId = payload.sub
@@ -47,7 +47,7 @@ describe('Nfts operations', () => {
       ddo = await nevermined.nfts1155.create(nftAttributes, artist)
     })
 
-    it('nft contract address is correct', async () => {
+    it('nft contract address is correct', () => {
       assert.equal(
         nevermined.assets.getNftContractAddress(ddo),
         nevermined.keeper.nftUpgradeable.address,
@@ -84,7 +84,7 @@ describe('Nfts operations', () => {
     })
   })
 
-  describe('with custom token', async () => {
+  describe('with custom token', () => {
     before(async () => {
       const metadata = getMetadata()
       metadata.userId = payload.sub
@@ -121,7 +121,7 @@ describe('Nfts operations', () => {
     })
   })
 
-  describe('with ether', async () => {
+  describe('with ether', () => {
     before(async () => {
       const metadata = getMetadata()
       metadata.userId = payload.sub

integration/nevermined/NFT721.test.ts

@@ -8,7 +8,7 @@ import { TokenUtils } from '../../src/nevermined'
 import { ethers } from 'ethers'
 import { ContractHandler, Nft721Contract, TransferNFT721Condition } from '../../src/keeper'
 
-describe('Nfts721 operations', async () => {
+describe('Nfts721 operations', () => {
   let nevermined: Nevermined
   let transferNft721Condition: TransferNFT721Condition
 
@@ -65,7 +65,7 @@ describe('Nfts721 operations', async () => {
     ;({ token } = nevermined.utils)
   })
 
-  describe('with default token', async () => {
+  describe('with default token', () => {
     before(async () => {
       const metadata = getMetadata()
       metadata.userId = payload.sub
@@ -122,7 +122,7 @@ describe('Nfts721 operations', async () => {
     })
   })
 
-  describe('with custom token', async () => {
+  describe('with custom token', () => {
     before(async () => {
       const metadata = getMetadata()
       metadata.userId = payload.sub
@@ -167,7 +167,7 @@ describe('Nfts721 operations', async () => {
     })
   })
 
-  describe('with ether', async () => {
+  describe('with ether', () => {
     before(async () => {
       const metadata = getMetadata()
       metadata.userId = payload.sub

integration/nevermined/NFTTemplatesWithEther.test.ts

@@ -27,7 +27,7 @@ import { ZeroAddress, parseEther } from '../../src/utils'
 import { getRoyaltyAttributes, RoyaltyAttributes, RoyaltyKind } from '../../src/nevermined'
 import { EventLog } from 'ethers'
 
-describe('NFTTemplates With Ether E2E', async () => {
+describe('NFTTemplates With Ether E2E', () => {
   let artist: Account
   let collector1: Account
   let collector2: Account
@@ -124,7 +124,7 @@ describe('NFTTemplates With Ether E2E', async () => {
     console.debug(`NETWORK FEE = ${fee}`)
   })
 
-  describe('Full flow', async () => {
+  describe('Full flow', () => {
     before(async () => {
       // initial balances
       initialBalances = {
@@ -182,7 +182,7 @@ describe('NFTTemplates With Ether E2E', async () => {
       ddo = await nevermined.nfts1155.create(nftAttributes, artist)
     })
 
-    describe('As an artist I want to register a new artwork', async () => {
+    describe('As an artist I want to register a new artwork', () => {
       it('I want to register a new artwork and tokenize (via NFT). I want to get 10% royalties', async () => {
         await nftUpgradeable.setApprovalForAll(transferNftCondition.address, true, artist)
 
@@ -191,7 +191,7 @@ describe('NFTTemplates With Ether E2E', async () => {
       })
     })
 
-    describe('As a collector I want to buy some art', async () => {
+    describe('As a collector I want to buy some art', () => {
       it('I am setting an agreement for buying a NFT', async () => {
         conditionIdLockPayment = await lockPaymentCondition.generateIdWithSeed(
           agreementId,
@@ -345,7 +345,7 @@ describe('NFTTemplates With Ether E2E', async () => {
       })
     })
 
-    describe('As an artist I want to give exclusive access to the collectors owning a specific NFT', async () => {
+    describe('As an artist I want to give exclusive access to the collectors owning a specific NFT', () => {
       it('The collector sets up the NFT access agreement', async () => {
         // Collector1: Create NFT access agreement
         conditionIdNFTHolder = await nftHolderCondition.generateIdWithSeed(

integration/nevermined/SecondaryMarket.test.ts

@@ -345,7 +345,7 @@ describe('Secondary Markets', () => {
         ddo.setNFTRewardsFromService('nft-sales', assetPrice2, collector1.getId())
       })
 
-      it('As collector1 I create and store an off-chain service agreement', async () => {
+      it('As collector1 I create and store an off-chain service agreement', () => {
         const nftSalesServiceAgreementTemplate = nftSalesTemplate.getServiceAgreementTemplate()
         const nftSalesTemplateConditions = nftSalesTemplate.getServiceAgreementTemplateConditions()
 

src/ddo/DDO.ts

@@ -240,7 +240,7 @@ export class DDO {
    * @param publicKey - Public key to be used on personal sign.
    * @returns Proof object.
    */
-  public async generateProof(publicKey: string): Promise<Proof> {
+  public generateProof(publicKey: string): Proof {
     const checksum = {}
     this.service.forEach((svc) => {
       checksum[svc.index] = this.checksum(
@@ -392,7 +392,7 @@ export class DDO {
    * @param seed the seed
    * @returns the string represeing the DID seed
    */
-  public async generateDidSeed(seed) {
+  public generateDidSeed(seed): string {
     return zeroX(this.checksum(JSON.stringify(seed)))
   }
 

src/events/ContractEvent.ts

@@ -20,7 +20,7 @@ export class ContractEvent extends NeverminedEvent {
     return instance
   }
 
-  public async getEventData(options: EventOptions): EventResult {
+  public getEventData(options: EventOptions): EventResult {
     if (!this.eventExists(options.eventName)) {
       throw new KeeperError(
         `Event "${options.eventName}" not found on contract "${this.contract.contractName}"`,
@@ -50,7 +50,7 @@ export class ContractEvent extends NeverminedEvent {
     }
   }
 
-  public async getBlockNumber(): Promise<number> {
+  public getBlockNumber(): Promise<number> {
     return this.web3.getBlockNumber()
   }
 

src/events/SubgraphEvent.ts

@@ -61,7 +61,7 @@ export class SubgraphEvent extends NeverminedEvent {
     }
   }
 
-  public async getPastEvents(options: EventOptions): EventResult {
+  public getPastEvents(options: EventOptions): EventResult {
     return this.getEventData(options)
   }
 

src/keeper/Keeper.ts

@@ -59,7 +59,7 @@ export class Keeper extends Instantiable {
    * Returns Keeper instance.
    * @returns {@link Keeper}
    */
-  public static async getInstance(config: InstantiableConfig): Promise<Keeper> {
+  public static getInstance(config: InstantiableConfig): Keeper {
     const keeper = new Keeper()
     keeper.setInstanceConfig(config)
     return keeper