Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press0 1122 #281

Merged
merged 6 commits into from
May 3, 2024
Merged

Press0 1122 #281

merged 6 commits into from
May 3, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

Updated README.md file, with Module responsibilities & Critical paths information.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

wpscholar
wpscholar requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create JIRA tickets to move the non-ecommerce related functionality out of the e-commerce module?

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

## Critical Paths

1. Ecommerce Module should display, `Home` page with site preview, links to Hosting brand a/c and links to pending & completed tasks to setup Ecommerce store.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site preview and links to hosting shouldn't be considered critical paths here as they aren't directly related to e-commerce functionality. Also, I don't think the completed tasks not showing is critical enough to consider a critical path. If a link didn't show or were wrong, we wouldn't do an emergency release to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know there was apparently an escalation which happened in past when site preview didn't work as expected so I have added site preview as critical functionality.
@chrisdavidmiles might have better idea about the issue.
Please let me know if site preview should be kept as a critical path or not.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coming soon not working is important functionality but I agree it's not something we'd do an out of cycle release for. And it shouldn't be in the ecommerce module anyway. There is planned work to move that elsewhere like coming soon module since it doesn't really have much to do with ecommerce per say.

Copy link
Contributor Author

@aratidgr8 aratidgr8 Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmiles
As dicussed with @wpscholar I have already added

  • JIRA in backlog to move site preview section from Ecommerce module.
  • JIRA in backlog to move Ready to go live section from Ecommerce module to wp-module-coming-soon

Removed site preview section from critical path description for Ecommerce module. You can review the updated content here
https://github.com/newfold-labs/wp-module-ecommerce/blob/3196d2bc76aab155458cb41b925494c44954aa51/README.md

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aratidgr8
Copy link
Contributor Author

aratidgr8 commented Apr 15, 2024 •
edited
Loading

@wpscholar I have currently created GitHub issues for some of changes, please review and confirm once. So, I can create JIRAs for the same.

@wpscholar
Copy link
Member

@aratidgr8 We still need a few changes here when you get a chance. Thanks!

@aratidgr8
Copy link
Contributor Author

@wpscholar JIRAs created,

@newfold-labs newfold-labs deleted a comment from bhwpteam Apr 25, 2024
@ramyakrishnai ramyakrishnai merged commit d4064bc into trunk May 3, 2024
@ramyakrishnai ramyakrishnai deleted the PRESS0-1122 branch May 3, 2024 09:22
@ramyakrishnai ramyakrishnai mentioned this pull request May 3, 2024
Merged
8 tasks
@mamatharao05 mamatharao05 mentioned this pull request May 3, 2024
Closed
@ramyakrishnai ramyakrishnai mentioned this pull request May 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpscholar wpscholar wpscholar approved these changes

@chrisdavidmiles chrisdavidmiles Awaiting requested review from chrisdavidmiles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aratidgr8 @wpscholar @chrisdavidmiles @ramyakrishnai