Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Press0 1122 #281
Press0 1122 #281
Changes from 2 commits
d8be85b
52169a3
ff26819
4369c4b
3196d2b
6a75392
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The site preview and links to hosting shouldn't be considered critical paths here as they aren't directly related to e-commerce functionality. Also, I don't think the completed tasks not showing is critical enough to consider a critical path. If a link didn't show or were wrong, we wouldn't do an emergency release to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know there was apparently an escalation which happened in past when
site preview
didn't work as expected so I have addedsite preview
as critical functionality.@chrisdavidmiles might have better idea about the issue.
Please let me know if
site preview
should be kept as a critical path or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coming soon not working is important functionality but I agree it's not something we'd do an out of cycle release for. And it shouldn't be in the ecommerce module anyway. There is planned work to move that elsewhere like coming soon module since it doesn't really have much to do with ecommerce per say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdavidmiles
As dicussed with @wpscholar I have already added
site preview
section from Ecommerce module.Ready to go live
section from Ecommerce module towp-module-coming-soon
Removed
site preview
section fromcritical path
description for Ecommerce module. You can review the updated content herehttps://github.com/newfold-labs/wp-module-ecommerce/blob/3196d2bc76aab155458cb41b925494c44954aa51/README.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.