Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR-347971 | OpenLineage event consumer writer #1887

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

devendra-nr
Copy link

Relevant information

Added domain and entities for Data Pipeline Observability product

Checklist

  • I've read the guidelines and understand the acceptance criteria.
  • The value of the attribute marked as identifier will be unique and valid.
  • I've confirmed that my entity type wasn't already defined. If it is I'm providing an explanation above.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@devendra-nr devendra-nr changed the title NR-347971 Olin event consumer writer NR-347971 OpenLineage event consumer writer Jan 30, 2025
github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Feb 2, 2025
- compositeIdentifier:
separator: ":"
attributes:
- dataset.namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest you prepend those tags with something specific of your domain/type e.g. openlineage.dataset.namespace.

dataset, job and pipeline are too broad and may end up matching unrelated metrics.

Copy link
Contributor

@otaviocarvalho otaviocarvalho Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to change it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otaviocarvalho Thanks for pointing this.
I have updated the PR with unique tags.

@devendra-nr devendra-nr changed the title NR-347971 OpenLineage event consumer writer NR-347971 | OpenLineage event consumer writer Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants