-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR-347971 | OpenLineage event consumer writer #1887
Open
devendra-nr
wants to merge
10
commits into
newrelic:main
Choose a base branch
from
devendra-nr:NR-347971-OLIN-event-consumer-writer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+135
−0
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e5ee948
OLIN agent collection
devendra-nr 234692f
Create DPO collections
devendra-nr 03ad233
NR-347971 OLIN agent collection
devendra-nr 8cf86d2
NR-347971 | Added identifiers and tags
devendra-nr 9680c79
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr 19db55c
Merge branch 'main' into NR-347971-OLIN-event-consumer-writer
devendra-nr b872e62
NR=347971 Update name as per OLIN spec
devendra-nr d654b44
NR-347971 Revert file change
devendra-nr 744128d
NR-347971 | Use unique tag names
devendra-nr addf09f
Merge branch 'newrelic:main' into NR-347971-OLIN-event-consumer-writer
devendra-nr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
domain: AGENT | ||
type: OPENLINEAGE | ||
configuration: | ||
entityExpirationTime: MANUAL | ||
alertable: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
domain: DPO | ||
type: DATASET_VERSIONS | ||
synthesis: | ||
rules: | ||
- compositeIdentifier: | ||
separator: ":" | ||
attributes: | ||
- dataset.namespace | ||
- dataset.name | ||
- updatedAt | ||
name: dataset.name | ||
encodeIdentifierInGUID: true | ||
conditions: | ||
- attribute: dataset.name | ||
tags: | ||
dataset.namespace: | ||
entityTagName: olin.dataset.namespace | ||
multiValue: false | ||
dataset.name: | ||
entityTagName: olin.dataset.name | ||
multiValue: false | ||
dataset.updatedAt: | ||
entityTagName: olin.dataset.updatedAt | ||
multiValue: false | ||
configuration: | ||
entityExpirationTime: MANUAL | ||
alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
domain: DPO | ||
type: DATASETS | ||
synthesis: | ||
rules: | ||
- compositeIdentifier: | ||
separator: ":" | ||
attributes: | ||
- dataset.namespace | ||
- dataset.name | ||
name: dataset.name | ||
encodeIdentifierInGUID: true | ||
conditions: | ||
- attribute: dataset.name | ||
tags: | ||
dataset.namespace: | ||
entityTagName: olin.dataset.namespace | ||
multiValue: false | ||
dataset.name: | ||
entityTagName: olin.dataset.name | ||
multiValue: false | ||
configuration: | ||
entityExpirationTime: MANUAL | ||
alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
domain: DPO | ||
type: JOB_VERSIONS | ||
synthesis: | ||
rules: | ||
- compositeIdentifier: | ||
separator: ":" | ||
attributes: | ||
- job.namespace | ||
- job.name | ||
- updatedAt | ||
name: job.name | ||
encodeIdentifierInGUID: true | ||
conditions: | ||
- attribute: job.name | ||
tags: | ||
job.namespace: | ||
entityTagName: olin.job.namespace | ||
multiValue: false | ||
job.name: | ||
entityTagName: olin.job.name | ||
multiValue: false | ||
job.updatedAt: | ||
entityTagName: olin.job.updatedAt | ||
multiValue: false | ||
pipeline.name: | ||
entityTagName: olin.pipeline.name | ||
multiValue: false | ||
configuration: | ||
entityExpirationTime: MANUAL | ||
alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
domain: DPO | ||
type: JOBS | ||
synthesis: | ||
rules: | ||
- compositeIdentifier: | ||
separator: ":" | ||
attributes: | ||
- job.namespace | ||
- job.name | ||
- eventTime | ||
name: job.name | ||
encodeIdentifierInGUID: true | ||
conditions: | ||
- attribute: job.name | ||
tags: | ||
job.namespace: | ||
entityTagName: olin.job.namespace | ||
multiValue: false | ||
job.name: | ||
entityTagName: olin.job.name | ||
multiValue: false | ||
pipeline.name: | ||
entityTagName: olin.pipeline.name | ||
multiValue: false | ||
configuration: | ||
entityExpirationTime: MANUAL | ||
alertable: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
domain: DPO | ||
type: PIPELINES | ||
synthesis: | ||
rules: | ||
- compositeIdentifier: | ||
separator: ":" | ||
attributes: | ||
- pipeline.namespace | ||
- pipeline.name | ||
name: pipeline.name | ||
encodeIdentifierInGUID: true | ||
conditions: | ||
- attribute: pipeline.name | ||
tags: | ||
pipeline.namespace: | ||
entityTagName: olin.pipeline.namespace | ||
multiValue: false | ||
pipeline.name: | ||
entityTagName: olin.pipeline.name | ||
multiValue: false | ||
configuration: | ||
entityExpirationTime: MANUAL | ||
alertable: true |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest you prepend those tags with something specific of your domain/type e.g.
openlineage.dataset.namespace
.dataset
,job
andpipeline
are too broad and may end up matching unrelated metrics.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@otaviocarvalho Thanks for pointing this.
I have updated the PR with unique tags.