-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable25] Detect aborted connection in OC\Files\View and stop writing data to the output buffer #40233
Conversation
output buffer Signed-off-by: Côme Chilliet <[email protected]>
4f9a3de
to
fe766dc
Compare
Signed-off-by: Côme Chilliet <[email protected]>
fe766dc
to
168b07d
Compare
/backport to stable26 |
/backport to stable27 |
/backport to master |
Co-authored-by: Benjamin Gaussorgues <[email protected]> Signed-off-by: Côme Chilliet <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
aef1115
to
6b2580d
Compare
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
The backport to master failed. Please do this backport manually. # Switch to the target branch and update it
git checkout master
git pull origin master
# Create the new backport branch
git checkout -b fix/foo-master
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-master More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
When reading a video through a public link, and moving the time picker to different times in the video, each request keeps running after being aborted by the web browser and that overloads the server.
This is not the same as sabre-io/http#207 because in this case the download does not go through dav.
Checklist