fix(cypress): Add timeout for waiting on Nextcloud server #41250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nickvergessen,
SystemKeeper,
blizzz and
skjnldsv
ChristophWurst
approved these changes
Nov 2, 2023
SystemKeeper
approved these changes
Nov 2, 2023
susnux
force-pushed
the
chore/cypress-timeout
branch
2 times, most recently
from
c6e2ac6 to
76e3a11
Compare
|
Timeout after 2m? Something fishy here, I will investigate. |
susnux
added
2. developing
susnux
force-pushed
the
chore/cypress-timeout
branch
from
76e3a11 to
70da355
Compare
nickvergessen
approved these changes
Nov 2, 2023
susnux
force-pushed
the
chore/cypress-timeout
branch
4 times, most recently
from
5a42306 to
a49b417
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/cypress-timeout
branch
from
a49b417 to
cdfa566
Compare
|
Looks like the runners were too crowded, but nothing I can do here. I created a follow up that will use GitHub workflow service for the Nextcloud server, which then will save (in best case) ~2 minutes. (best case = when CI is fast, in cases like midday it might save even more CI time). The follow up: #41252 |
susnux
added
3. to review
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not wast CI time if docker setup of the Nextcloud server went wrong.
Checklist