-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cypress] Use GitHub action service for Nextcloud server #41252
Conversation
Do you know why? I mean, both are running docker? This look like a crazy difference 🤯 |
I guess because services are cached and created on the beginn while manually starting docker happens on step evaluation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach.
I'd be happy to save 2 min per cypress runner.
I'm wondering if there are any downsides to this but can't think of any. The only thing that comes to my mind is that we may need to maintain multiple images at some point so once this lands on stable branches they still have a container that works for them. But i guess we'll need the images anyway and can just configure them in the cypress.yml accordingly.
a8edfaa
to
d5e8cc5
Compare
08461da
to
b21957d
Compare
39158c0
to
90b734f
Compare
Seems like it's failing much more randomly with that PR 🤔 |
|
Signed-off-by: Ferdinand Thiessen <[email protected]>
…a cypress cloud service again Signed-off-by: John Molakvoæ <[email protected]>
90b734f
to
41f6c9f
Compare
Cypress failure handling needs a fix |
Pull request was closed
Summary
Follow up on #41250
This changes the Cypress workflow to not start a docker container from Cypress but use a GitHub workflow service as the Nextcloud container.
This saves ~2 minutes CI time per Cypress runner (currently 3).
Also the service is up when the workflow starts meaning cypress does not have to wait for it and should no longer time out.
Checklist