fix(files): Allow Ctrl/Command click on file entries to open in a new tab

[juliusknorr]

Bring back opening files in a new tab by Ctrl-clicking on the file list entry. metaKey is needed for macOS support.

[juliusknorr]

/backport to stable28

[skjnldsv]

/compile /

[juliusknorr]

/compile

[skjnldsv]

The bot is soooo weird @juliushaertl

[juliusknorr]

I restarted the action manually as it didn't seem to be working smoothly on self-hosted runners

[juliusknorr]

Reference for the failure https://github.com/nextcloud/server/actions/runs/7336566796/job/19976090810?pr=42457

[skjnldsv]

Oooh, it fails if init ran on a different runner type than process

[backportbot-nextcloud]

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[juliusknorr]

/backport 2c7f632 to stable28

[ShGKme]

This solution overrides browser default behavior. While it allows to open link on new tab, the link is still invalid:

• Middle click is invalid
• Context menu is invalid
• title and attributes are invalid

For example, for a folder it says that it is a link to download a file via /remote.php while actually click opens a folder.

[ShGKme]

This line doesn't work, we cannot take data from another child through parent on initial render. There is no another child on this moment.

server/apps/files/src/components/FileEntry/FileEntryName.vue

Line 150 in 7c79521

const enabledDefaultActions = this.$parent?.$refs?.actions?.enabledDefaultActions

And anyway I don't think it is a good approach to transfer data by manually going through nodes...

[juliusknorr]

I'm not sure what URL I would expect...

• Internal file link (/f/12345) would work for middle click and context menu open in new tab/window, but would not work when using the browsers "Save link as"
• WebDAV URL does not work for open in a new tab then

[ShGKme]

Link should be the same as what it opens. If a link opens /foo/bar, then it should have href /foo/bar.

Here it also makes the link download link and the title says "Download".

The source of the issue is that this line, that was supposed to find the default action, fails on initial rendering.

There is the default action for a folder (open it), but this line on component creation doesn't work, because it tries to get data from another not mounted component, not from the state.