Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] ci: fail psalm when baseline update required #48471

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 30, 2024

Backport of PR #48466

@backportbot backportbot bot added the 3. to review Waiting for reviews label Sep 30, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.8 milestone Sep 30, 2024
@provokateurin
Copy link
Member

Meh now we have some diff because of the CDATA stuff which is somehow inconsistent 😢

@kesselb kesselb force-pushed the backport/48466/stable29 branch from f26b318 to 7286b35 Compare September 30, 2024 21:28
@kesselb
Copy link
Contributor

kesselb commented Sep 30, 2024

Meh now we have some diff because of the CDATA stuff which is somehow inconsistent

Yep, we need psalm ~5.22 to have a stable psalm baseline: vimeo/psalm#10632

@Altahrim Altahrim mentioned this pull request Oct 1, 2024
1 task
@blizzz blizzz mentioned this pull request Oct 10, 2024
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
4 tasks
@Altahrim
Copy link
Collaborator

Conflict with psalm baseline

@kesselb kesselb force-pushed the backport/48466/stable29 branch from 3379869 to 2828dd8 Compare October 30, 2024 14:34
To ensure we have a stable baseline

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the backport/48466/stable29 branch from 2828dd8 to c9b0742 Compare October 30, 2024 14:36
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the backport/48466/stable29 branch from c9b0742 to 8469e1a Compare October 30, 2024 14:54
@kesselb
Copy link
Contributor

kesselb commented Oct 30, 2024

Conflicts resolved.

@kesselb kesselb merged commit e25f205 into stable29 Oct 30, 2024
184 checks passed
@kesselb kesselb deleted the backport/48466/stable29 branch October 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants