Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): Update caption for screen readers when uploading is not possible #49167

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 8, 2024

Part of: #5534

Summary

Updates the caption with helpful messages when the user cannot upload into the folder. These messages were never read before as they were labelling a disabled button which is invisible to screen readers.

Checklist

@Pytal Pytal added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews accessibility labels Nov 8, 2024
@Pytal Pytal added this to the Nextcloud 31 milestone Nov 8, 2024
@Pytal Pytal self-assigned this Nov 8, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner November 8, 2024 19:47
@Pytal
Copy link
Member Author

Pytal commented Nov 8, 2024

/compile /

@skjnldsv skjnldsv self-assigned this Nov 20, 2024
@Pytal Pytal force-pushed the feat/caption-cant-upload branch from b0bd996 to feb7800 Compare December 3, 2024 23:50
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 3, 2024
@Pytal

This comment was marked as outdated.

@Pytal Pytal enabled auto-merge December 3, 2024 23:50
@Pytal Pytal force-pushed the feat/caption-cant-upload branch from 8ab2f5a to 11e77c0 Compare December 3, 2024 23:58
@Pytal

This comment was marked as outdated.

@Pytal Pytal force-pushed the feat/caption-cant-upload branch from 91014fd to 228d8c9 Compare December 4, 2024 00:26
@Pytal
Copy link
Member Author

Pytal commented Dec 4, 2024

/compile

Signed-off-by: nextcloud-command <[email protected]>
@Pytal Pytal merged commit d97d1bd into master Dec 4, 2024
120 checks passed
@Pytal Pytal deleted the feat/caption-cant-upload branch December 4, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants