Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open internal file share links in chat via files client #3329

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Open internal file share links in chat via files client #3329

merged 3 commits into from
Sep 21, 2023

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Sep 20, 2023 •
edited
Loading

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@tobiasKaminsky
extracted and created tests
838b14b 
Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 20, 2023
@AndyScherzinger AndyScherzinger changed the title Implement first steps for sending file share links to files client Open internal file share links in chat via files client Sep 20, 2023
@AndyScherzinger AndyScherzinger added this to the 17.2.0 milestone Sep 20, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/noid/openFileShareLinkInFilesApp branch from 14db605 to 3cb6321 Compare September 20, 2023 21:13
@AndyScherzinger AndyScherzinger marked this pull request as ready for review September 20, 2023 21:14
@AndyScherzinger AndyScherzinger force-pushed the feature/noid/openFileShareLinkInFilesApp branch from 3cb6321 to da1742f Compare September 20, 2023 21:21
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3329-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9393
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total150150

@AndyScherzinger AndyScherzinger merged commit 28ec0ba into master Sep 21, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/openFileShareLinkInFilesApp branch September 21, 2023 21:17
@AndyScherzinger
Copy link
Member Author

works for Tobias and me

@mahibi mahibi mentioned this pull request Sep 26, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: 🗨️ chat feature: 🧩 integration
Projects
None yet
Milestone
18.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @tobiasKaminsky