Bug Fix - IllegalStateException in stopAudioRecording + Polishes

[rapterjet2004]

• fixes IllegalStateException in stopAudioRecording #3302

I decided to also implement some additional Bug fixes and some refactoring, in addition to the IllegalStateException bug fix. Figured it would be better than multiple PR's.

• Fixes IllegalStateException
• Refactored code to be clearer and manage the state of the MediaRecorder object directly
• Saves state of voice recording upon life cycle changes like what telegram has
• Waveform is now saved to storage, so it isn't recreated every time the user exits the activity
• Clicking the expanded restart record button while preview is playing stops the preview
• File captions don't crash now, when the itemView is clicked
• Note to Self now allows messages expired or all messages to be deleted

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

i get "mediarecorder went away with unhandled events" when doing:

1. start and lock media recording
2. click delete

[mahibi]

great improvements 👍
from my pov this can be merged when the minor comments are solved.

[mahibi]

In general it's better to seperate the changes into multiple PR's, especially when different features are touched.

[mahibi]

/backport to stable-18.0

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	85	85
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	123	123
Internationalization	5	5
Malicious code vulnerability	3	3
Performance	8	8
Security	2	2
Total	157	157

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3453-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!