Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace icon #4480

Closed
wants to merge 5 commits into from
Closed

Replace icon #4480

wants to merge 5 commits into from

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4466

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch
add conversation public icon
ec58327 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use material icon
2920946 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
rename icon and delete unused icons
e8c4771 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add copyright
1827310 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
use default image
ab9e367 
Signed-off-by: sowjanyakch <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4480-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94157
Errors13276

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Lint increased!

@AndyScherzinger AndyScherzinger mentioned this pull request Dec 2, 2024
Merged
5 tasks
@mahibi mahibi closed this in #4505 Dec 2, 2024
@AndyScherzinger AndyScherzinger deleted the replace_icon branch December 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace LinkVariant material icon with Link icon
1 participant
@sowjanyakch