-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io.read_metadata does not always set index dtype as expected #925
Comments
Seems like this was fixed in pandas 1.4.0, should we bump minimum requirement in setup.py? |
Hmm, starting with pandas 1.4.0, they only support Python 3.8 and higher. Maybe we should just work around it to avoid bumping the minimum Python dependency for Augur. |
Augur currently also requires Python 3.8 or higher — could we maybe resolve this old issue by bumping our minimum Pandsas requirement? |
Earlier versions have a bug that prevented augur.io.read_metadata from properly setting the index column's data type. <#925>
Current Behavior
We try to explicitly set the dtype for the index column within
io.read_metadata
:augur/augur/io.py
Lines 116 to 121 in 139ba04
However, this does not work as expected because of a bug in pandas where the dtype is ignored for
index_col
.Additional context
Found this issue when looking into nextstrain/ncov#948
The text was updated successfully, but these errors were encountered: