Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[preview 4] Redesign panel sections in sidebar #1721

Closed
wants to merge 13 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename "Panel Options" to "Display"
I chose the title "Display" even though it is called "layout" in the
state because "Layout" is already used to describe tree layout, and I
didn't want translations to conflict.

I also contemplated putting this control at the top. However, its
conditional rendering worsens usability upon toggling panel visibility,
as the scroll position is changed due to its placement above the
toggles.
victorlin committed Nov 13, 2023
commit 404e2d4fa5a99356a11df2e172b6c04e5a4b93f6
4 changes: 2 additions & 2 deletions src/components/controls/controls.tsx
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ import ToggleTangle from "./toggle-tangle";
import Language from "./language";
import { ControlsContainer } from "./styles";
import FilterData, {FilterInfo} from "./filter";
import {TreeInfo, MapInfo, AnimationOptionsInfo, PanelOptionsInfo,
import {TreeInfo, MapInfo, AnimationOptionsInfo, PanelLayoutInfo,
ExplodeTreeInfo, EntropyInfo, FrequencyInfo, MeasurementsInfo} from "./miscInfoText";
import { ControlHeader } from "./controlHeader";
import MeasurementsOptions from "./measurementsOptions";
@@ -118,7 +118,7 @@ function Controls() {
{canTogglePanelLayout &&
<>
<span style={{ paddingTop: "10px" }} />
<ControlHeader title={t("sidebar:Panel Options")} tooltip={PanelOptionsInfo} />
<ControlHeader title={t("sidebar:Display")} tooltip={PanelLayoutInfo} />
<PanelLayout />
</>
}
2 changes: 1 addition & 1 deletion src/components/controls/miscInfoText.js
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ export const AnimationOptionsInfo = (
</>
);

export const PanelOptionsInfo = (
export const PanelLayoutInfo = (
<>
Control whether to show the tree and the map side-by-side (<em>grid</em>) or expanded (<em>full</em>).
</>
1 change: 0 additions & 1 deletion src/locales/ar/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "سرعة الحركة",
"Loop animation": "حركة متكررة",
"Animate cumulative history": "تحريك التاريخ التراكمي",
"Panel Options": "خيارات اللوحة",
"Tree": "الشجرة",
"Map": "الخريطة",
"Entropy": "الانتروبيا",
1 change: 0 additions & 1 deletion src/locales/de/sidebar.json
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@
"Animation Speed": "Geschwindigkeit der Animation",
"Loop animation": "In einer Schleife animieren",
"Animate cumulative history": "Gesamten Verlauf miteinbeziehen",
"Panel Options": "Hauptansicht-Einstellungen",
"Tree": "Baum",
"Map": "Karte",
"Entropy": "Entropie",
2 changes: 1 addition & 1 deletion src/locales/en/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@
"Animation Speed": "Animation Speed",
"Loop animation": "Loop animation",
"Animate cumulative history": "Animate cumulative history",
"Panel Options": "Panel Options",
"Display": "Display",
"Tree": "Tree",
"Map": "Map",
"Entropy": "Entropy",
1 change: 0 additions & 1 deletion src/locales/es/sidebar.json
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@
"Animation Speed": "Velocidad de la animación",
"Loop animation": "Repitir la animación",
"Animate cumulative history": "Animar historial cumulativo",
"Panel Options": "Opciones del panel",
"Tree": "Árbol",
"Map": "Mapa",
"Entropy": "Entropía",
1 change: 0 additions & 1 deletion src/locales/fr/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "Vitesse d'animation",
"Loop animation": "Animation en boucle",
"Animate cumulative history": "Animer l'historique cumulatif",
"Panel Options": "Options du panneau",
"Tree": "Arbre",
"Map": "Carte",
"Entropy": "Entropie",
1 change: 0 additions & 1 deletion src/locales/it/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "Velocità di animazioni",
"Loop animation": "Animazioni in loop",
"Animate cumulative history": "Animare la storia cumulativa",
"Panel Options": "Opzioni di pannello",
"Tree": "Albero",
"Map": "Mappa",
"Entropy": "Entropia",
1 change: 0 additions & 1 deletion src/locales/ja/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "アニメーション速度",
"Loop animation": "アニメーションを繰り返し",
"Animate cumulative history": "累積の履歴をアニメーション",
"Panel Options": "パネルのオプション",
"Tree": "ツリー",
"Map": "地図",
"Entropy": "エントロピー",
1 change: 0 additions & 1 deletion src/locales/lt/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "Animacijos greitis",
"Loop animation": "Kartoti laiko atkarpą",
"Animate cumulative history": "Rodyti kauptinę istoriją",
"Panel Options": "Langų parinktys",
"Tree": "Medį",
"Map": "Žemėlapį",
"Entropy": "Entropiją",
1 change: 0 additions & 1 deletion src/locales/pl/sidebar.json
Original file line number Diff line number Diff line change
@@ -21,7 +21,6 @@
"Animation Speed": "Szybkość animacji",
"Loop animation": "Animacja pętli",
"Animate cumulative history": "Animuj historię zbiorczą",
"Panel Options": "Opcje panelu",
"Tree": "Drzewo",
"Map": "Mapę",
"Entropy": "Entropię",
1 change: 0 additions & 1 deletion src/locales/pt/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "Velocidade de Animação",
"Loop animation": "Repetir a animação",
"Animate cumulative history": "Animar o histórico acumulado",
"Panel Options": "Painel de Opções",
"Tree": "Árvore",
"Map": "Mapa",
"Entropy": "Entropia",
1 change: 0 additions & 1 deletion src/locales/ru/sidebar.json
Original file line number Diff line number Diff line change
@@ -17,7 +17,6 @@
"Animation Speed": "Скорость Анимации",
"Loop animation": "Повтор анимации",
"Animate cumulative history": "Анимировать кумулятивную историю",
"Panel Options": "Настройки Панели",
"Tree": "Дерево",
"Map": "Карту",
"Entropy": "Энтропию",
1 change: 0 additions & 1 deletion src/locales/tr/sidebar.json
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"Animation Speed": "Animasyon Hızı",
"Loop animation": "Döngülü animasyon",
"Animate cumulative history": "Kümülatif tarihçeyi canlandır",
"Panel Options": "Panel Seçenekleri",
"Tree": "Ağacı",
"Map": "Haritayı",
"Entropy": "Entropiyi",