CI: Update test-pathogen-repo-ci #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2024
joverlee521
commented
Jul 17, 2024
genehack
approved these changes
Jul 17, 2024
This was referenced Jul 17, 2024
joverlee521
added a commit
to nextstrain/docker-base
that referenced
this pull request
Jul 19, 2024
As per @victorlin 's recommendation in related change in conda-base,¹ these pathogens can get updated as post-merge tasks for eventual PRs. ¹ <nextstrain/conda-base#85 (comment)>
joverlee521
added a commit
to nextstrain/augur
that referenced
this pull request
Jul 19, 2024
As per @victorlin 's recommendation in related change in conda-base,¹ these pathogens can get updated as post-merge tasks for eventual PRs. ¹ <nextstrain/conda-base#85 (comment)>
victorlin
approved these changes
Jul 22, 2024
victorlin
reviewed
Jul 22, 2024
Add comments to clearly show the job using pathogen-repo-ci@v0 is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to a old tag of the `pathogen-repo-ci`, the job should not be expected to be updated. Any new pathogen repos should be added to the `test-pathogen-repo-ci` job which uses the latest version of `pathogen-repo-ci`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add comments to clearly show the job using pathogen-repo-ci@v0 is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to a old tag of the
pathogen-repo-ci, the job should not be expected to be updated.Any new pathogen repos should be added to the
test-pathogen-repo-cijob which uses the latest version ofpathogen-repo-ci.Related issue(s)
Prompted by #83 (comment)
Resolves #78
Related to nextstrain/.github#84
Checklist