Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Sort environment.yml dependencies #7085

Merged
merged 10 commits into from
Feb 3, 2025
Merged

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Nov 25, 2024

This fixes an issue with the Seqera containers naming.

The Seqera containers site doesn't care about the context of what module the
image is for. It just sorts the dependencies.

This avoids having multiple containers with a bunch of different names.

Should probably handle that on the wave-cli side.

@edmundmiller edmundmiller self-assigned this Nov 25, 2024
@edmundmiller edmundmiller changed the title style: Add sort-simple-yaml style: Sort environment.yml dependencies Nov 25, 2024
@edmundmiller
Copy link
Contributor Author

Not going to do the 1258 environment.yml updates here, just going to let those get added as people make changes to them. Like a river carving through a mountain.

edmundmiller and others added 10 commits January 29, 2025 10:45
This fixes an issue with the Seqera containers naming.

The Seqera containers site doesn't care about the context of what module the
image is for. It just sorts the dependencies.

This avoids having multiple containers with a bunch of different names.

Should probably handle that on the wave-cli side.
https://github.com/MarcoGorelli/madforhooks has been archived so I just
copied this into the repo to make it simple to use
conda-env-sorter doesn't make the files pretty
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Do you know why tests are failing? they don't show an error message

@edmundmiller edmundmiller merged commit a4d916a into master Feb 3, 2025
98 of 121 checks passed
@edmundmiller edmundmiller deleted the sort-enviroment-ymls branch February 3, 2025 14:38
@edmundmiller
Copy link
Contributor Author

Merging as all of the pre-commit checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants