Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy from fix #153

Merged
merged 6 commits into from
Feb 17, 2025
Merged

copy from fix #153

merged 6 commits into from
Feb 17, 2025

Conversation

kubranarci
Copy link
Contributor

copy solution from https://github.com/nf-core/tools/pull/3399/files#diff-b7de22f5cca29de9c78246fa5f396c2e709e848b9d44f41854e49797c6452c06

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

mashehu
mashehu approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed some templating code artifacts

@kubranarci
Copy link
Contributor Author

@mashehu Thank you!!! 👯‍♀️

@kubranarci kubranarci merged commit 4191a18 into dev Feb 17, 2025
13 checks passed
@kubranarci kubranarci deleted the template_issue branch February 17, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubranarci @mashehu