Warning button variant #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankieroberto
previously approved these changes
Jun 28, 2024
|
Thanks @paulrobertlloyd this helpful. We'll need to hold this until we can add the guidance to the design system: nhsuk/nhsuk-service-manual#1995 Should be able to use the gov.uk guidance, I don't think there's anything else specific we'd need to add/amend? |
anandamaryon1
added
the
blocked
|
Guidance added in this PR: nhsuk/nhsuk-service-manual#1999 @anandamaryon1 I think this is un-blocked now? |
|
Ah, one small thing, do you mind if I/we change the example button label to align with the design system documentation? (It's something we want to do moving forward, to ensure both are aligned to avoid confusion). |
|
@anandamaryon1 ah do you mean change from "Delete account" to "Yes, delete this vaccine"? |
anandamaryon1
previously approved these changes
Jul 16, 2024
anandamaryon1
removed
the
blocked
frankieroberto
previously approved these changes
Jul 16, 2024
frankieroberto
dismissed stale reviews from anandamaryon1 and themself
via
6aecc7d
frankieroberto
approved these changes
Jul 16, 2024
|
Merged, thanks @paulrobertlloyd and @anandamaryon1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On our staff facing service, we use interruption screens that warn a user before they proceed to undertake an action that is destructive and/or cannot be undone. On these pages, we use also a red warning button to further indicate that a destructive action will take place:
This follows a similar pattern from the GOV.UK Design System:
This PR proposes adding an equivalent
--warningvariant tonhsuk-button. In the corresponding Service Manual guidance for this component, we can start by using the same guidance as that used in the GOV.UK Design System.Technical note
The SCSS for each button variant currently includes a lot of repeated properties that shouldn’t need redeclaring given each modifier inherits from the base class. That’s a separate issue, so for this PR, I’ve maintained the same implementation and redeclared properties for this variant.
Checklist